Update to NET 8 SDK #422
Update to NET 8 SDK #422
Conversation
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
You agree this file is not required, or am I missing something?
There was a problem hiding this comment.
Even more than when the next OS image is updated and doesn't have this one it would break.
There was a problem hiding this comment.
Well you are missing the fact that the solution does not require NET 8 SDK because nothing targets net8.0 yet. This will lead to the fact that depending the SDK you have (say 6 or 8) you will get different output folders (UseArtifactsOutput) and the tests will break.
So when the targets will be updated to net8.0 it will implicitly require the SDK and this file can be removed. But I discovered that there's regex changes that break the tests when run under net8.0 so requires some work.
There was a problem hiding this comment.
So this is to enfore that 8.0 sdk is used because of UseArtifactsOutput, ok.
There was a problem hiding this comment.
Yes, for the time being. A useful features but can break things if solution is used with older SDK.
Ensures consistent test path resolution when
UseArtifactsOutputis in use.