Ensure consuming works from C# language version 8 (#954)

sebastienros · Aug 31, 2021 · 2548f06 · 2548f06
1 parent d8282ef
commit 2548f06
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/Jint.Tests/Jint.Tests.csproj b/Jint.Tests/Jint.Tests.csproj
@@ -5,7 +5,11 @@
     <AssemblyOriginatorKeyFile>..\Jint\Jint.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
     <IsPackable>false</IsPackable>
-    <LangVersion>latest</LangVersion>
+    <!--
+      Unity currently supports only C# 8 so ensure we can use the features Jint introduces
+      https://docs.unity3d.com/Manual/CSharpCompiler.html
+    -->
+    <LangVersion>8</LangVersion>
     <NoWarn>612</NoWarn>
   </PropertyGroup>
   <ItemGroup>

diff --git a/Jint/Runtime/Interop/TypeResolver.cs b/Jint/Runtime/Interop/TypeResolver.cs
@@ -19,13 +19,13 @@ public sealed class TypeResolver
         /// <summary>
         /// Registers a filter that determines whether given member is wrapped to interop or returned as undefined.
         /// </summary>
-        public Predicate<MemberInfo> MemberFilter { get; init; } = _ => true;
+        public Predicate<MemberInfo> MemberFilter { get; set; } = _ => true;
 
         /// <summary>
         /// Sets member name comparison strategy when finding CLR objects members.
         /// By default member's first character casing is ignored and rest of the name is compared with strict equality.
         /// </summary>
-        public StringComparer MemberNameComparer { get; init; } = DefaultMemberNameComparer.Instance;
+        public StringComparer MemberNameComparer { get; set; } = DefaultMemberNameComparer.Instance;
 
         internal ReflectionAccessor GetAccessor(Engine engine, Type type, string member, Func<ReflectionAccessor> accessorFactory = null)
         {