share common base class for exceptions (#679)

sebastienros · Oct 27, 2019 · a8d19f3 · a8d19f3
1 parent 3464344
commit a8d19f3
Show file tree

Hide file tree

Showing 7 changed files with 39 additions and 21 deletions.
diff --git a/Jint/Runtime/JavaScriptException.cs b/Jint/Runtime/JavaScriptException.cs
@@ -7,7 +7,7 @@
 
 namespace Jint.Runtime
 {
-    public class JavaScriptException : Exception
+    public class JavaScriptException : JintException
     {
         private string _callStack;
 

diff --git a/Jint/Runtime/JintException.cs b/Jint/Runtime/JintException.cs
@@ -0,0 +1,28 @@
+using System;
+using System.Runtime.Serialization;
+
+namespace Jint.Runtime
+{
+    /// <summary>
+    /// Base class for exceptions thrown by Jint.
+    /// </summary>
+    [Serializable]
+    public abstract class JintException : Exception
+    {
+        protected JintException()
+        {
+        }
+
+        protected JintException(SerializationInfo info, StreamingContext context) : base(info, context)
+        {
+        }
+
+        protected JintException(string message) : base(message)
+        {
+        }
+
+        protected JintException(string message, Exception innerException) : base(message, innerException)
+        {
+        }
+    }
+}
diff --git a/Jint/Runtime/MemoryLimitExceededException.cs b/Jint/Runtime/MemoryLimitExceededException.cs
@@ -1,8 +1,6 @@
-using System;
-
-namespace Jint.Runtime
+namespace Jint.Runtime
 {
-    public class MemoryLimitExceededException : Exception
+    public class MemoryLimitExceededException : JintException
     {
         public MemoryLimitExceededException() : base()
         {

diff --git a/Jint/Runtime/RangeErrorException.cs b/Jint/Runtime/RangeErrorException.cs
@@ -1,11 +1,9 @@
-using System;
-
-namespace Jint.Runtime
+namespace Jint.Runtime
 {
     /// <summary>
     /// Workaround for situation where engine is not easily accessible.
     /// </summary>
-    internal sealed class RangeErrorException : Exception
+    internal sealed class RangeErrorException : JintException
     {
         public RangeErrorException(string message) : base(message)
         {

diff --git a/Jint/Runtime/RecursionDepthOverflowException.cs b/Jint/Runtime/RecursionDepthOverflowException.cs
@@ -1,10 +1,8 @@
-using System;
+using Jint.Runtime.CallStack;
 
 namespace Jint.Runtime
 {
-    using Jint.Runtime.CallStack;
-
-    public class RecursionDepthOverflowException : Exception
+    public class RecursionDepthOverflowException : JintException
     {
         public string CallChain { get; private set; }
 

diff --git a/Jint/Runtime/StatementsCountOverflowException.cs b/Jint/Runtime/StatementsCountOverflowException.cs
@@ -1,8 +1,6 @@
-using System;
-
-namespace Jint.Runtime
+namespace Jint.Runtime
 {
-    public class StatementsCountOverflowException : Exception 
+    public class StatementsCountOverflowException : JintException 
     {
         public StatementsCountOverflowException() : base("The maximum number of statements executed have been reached.")
         {

diff --git a/Jint/Runtime/TypeErrorException.cs b/Jint/Runtime/TypeErrorException.cs
@@ -1,11 +1,9 @@
-using System;
-
-namespace Jint.Runtime
+namespace Jint.Runtime
 {
     /// <summary>
     /// Workaround for situation where engine is not easily accessible.
     /// </summary>
-    internal sealed class TypeErrorException : Exception
+    internal sealed class TypeErrorException : JintException
     {
         public TypeErrorException(string message) : base(message)
         {