Fix reference checks after delete (#1095)

sebastienros · Feb 20, 2022 · e31a0a7 · e31a0a7
1 parent b271cef
commit e31a0a7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 33 deletions.
diff --git a/Jint.Tests.Test262/test/language/expressions/assignment/S11.13.1_A5_T4.js b/Jint.Tests.Test262/test/language/expressions/assignment/S11.13.1_A5_T4.js
diff --git a/Jint/Runtime/Environments/GlobalEnvironmentRecord.cs b/Jint/Runtime/Environments/GlobalEnvironmentRecord.cs
@@ -130,10 +130,13 @@ public override void SetMutableBinding(string name, JsValue value, bool strict)
             {
                 // fast inlined path as we know we target global, otherwise would be
                 // _objectRecord.SetMutableBinding(name, value, strict);
-                if (!_global.Set(name, value) && strict)
+                var property = JsString.Create(name);
+                if (strict && !_global.HasProperty(property))
                 {
-                    ExceptionHelper.ThrowTypeError(_engine.Realm);
+                    ExceptionHelper.ThrowReferenceError(_engine.Realm, name);
                 }
+
+                _global.Set(property, value);
             }
         }
 

diff --git a/Jint/Runtime/Environments/ObjectEnvironmentRecord.cs b/Jint/Runtime/Environments/ObjectEnvironmentRecord.cs
@@ -138,10 +138,12 @@ public override void SetMutableBinding(string name, JsValue value, bool strict)
 
         internal override void SetMutableBinding(in BindingName name, JsValue value, bool strict)
         {
-            if (!_bindingObject.Set(name.StringValue, value) && strict)
+            if (strict && !_bindingObject.HasProperty(name.StringValue))
             {
-                ExceptionHelper.ThrowTypeError(_engine.Realm);
+                ExceptionHelper.ThrowReferenceError(_engine.Realm, name.Key);
             }
+
+            _bindingObject.Set(name.StringValue, value);
         }
 
         public override JsValue GetBindingValue(string name, bool strict)

diff --git a/Jint/Runtime/Interpreter/Expressions/JintBinaryExpression.cs b/Jint/Runtime/Interpreter/Expressions/JintBinaryExpression.cs
@@ -356,7 +356,7 @@ protected override ExpressionResult EvaluateInternal(EvaluationContext context)
                     var leftNumeric = TypeConverter.ToNumeric(left);
                     var rightNumeric = TypeConverter.ToNumeric(right);
 
-                    if (leftNumeric.IsNumber())
+                    if (leftNumeric.IsNumber() && rightNumeric.IsNumber())
                     {
                         result = JsNumber.Create(leftNumeric.AsNumber() * rightNumeric.AsNumber());
                     }