create array directly bypassing conversions

sebastienros · May 30, 2021 · fd7e301 · fd7e301
1 parent 12d8778
commit fd7e301
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Jint/Native/Array/ArrayConstructor.cs b/Jint/Native/Array/ArrayConstructor.cs
@@ -381,6 +381,16 @@ private ArrayInstance ConstructArrayFromIEnumerable(IEnumerable enumerable)
             return jsArray;
         }
 
+        internal ArrayInstance ConstructFast(List<JsValue> contents)
+        {
+            var instance = ConstructFast((ulong) contents.Count);
+            for (var i = 0; i < contents.Count; i++)
+            {
+                instance.SetIndexValue((uint) i, contents[i], updateLength: false);
+            }
+            return instance;
+        }
+
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         internal ArrayInstance ConstructFast(ulong length)
         {

diff --git a/Jint/Native/Promise/PromiseConstructor.cs b/Jint/Native/Promise/PromiseConstructor.cs
@@ -17,7 +17,6 @@ internal sealed record PromiseCapability(
         JsValue RejectObj
     );
 
-
     public sealed class PromiseConstructor : FunctionInstance, IConstructor
     {
         private static readonly JsString _functionName = new JsString("Promise");
@@ -230,8 +229,8 @@ void ResolveIfFinished()
                 // if "then" method is sync then it will be resolved BEFORE the next iteration cycle
                 if (results.TrueForAll(static x => x != null) && doneIterating)
                 {
-                    resolve.Call(Undefined,
-                        new JsValue[] {Engine.Array.Construct(results.ToArray())});
+                    var array = _engine.Array.ConstructFast(results);
+                    resolve.Call(Undefined, new JsValue[] { array });
                 }
             }