Don't require Realm in Constructor public constructor (#1441)

sebastienros · Feb 18, 2023 · fedd680 · fedd680
1 parent 5eb6b82
commit fedd680
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Jint.Tests.PublicInterface/ConstructorTests.cs b/Jint.Tests.PublicInterface/ConstructorTests.cs
@@ -54,7 +54,7 @@ public void CanThrowTypeError()
 
 file sealed class DateOnlyConstructor : Constructor
 {
-    public DateOnlyConstructor(Engine engine) : base(engine, engine.Realm, (JsString) "DateOnly")
+    public DateOnlyConstructor(Engine engine) : base(engine, "DateOnly")
     {
     }
 

diff --git a/Jint/Native/Constructor.cs b/Jint/Native/Constructor.cs
@@ -6,7 +6,11 @@ namespace Jint.Native;
 
 public abstract class Constructor : FunctionInstance, IConstructor
 {
-    protected Constructor(Engine engine, Realm realm, JsString name) : base(engine, realm, name)
+    protected Constructor(Engine engine, string name) : this(engine, engine.Realm, new JsString(name))
+    {
+    }
+
+    internal Constructor(Engine engine, Realm realm, JsString name) : base(engine, realm, name)
     {
     }