Generic string-keyed dictionary indexing under interop #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
fix-jobject-string-indexer
branch
2 times, most recently
from
f6cc206
to
1d2b278
Compare
lahma
force-pushed
the
fix-jobject-string-indexer
branch
from
1d2b278
to
bbe3d1c
Compare
|
Only improvement would be to create a delegate instead of invoking the PropertyInfo. |
sebastienros
approved these changes
Nov 5, 2021
|
I think Delegate would require binding to target, here we have static type information and resolved Property which needs to be called with provided target. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1001