Improve operator overloading logic #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleanup and refactor code * use struct record instead of value tuples and custom code * prefer more specific types over object * prefer CLR array against JS array match over changing types
sebastienros
approved these changes
Nov 19, 2021
|
|
||
| var castOperator = _knownCastOperators.GetOrAdd(key, _ => | ||
| valueType.GetOperatorOverloadMethods() | ||
| .Concat(type.GetOperatorOverloadMethods()) | ||
| .FirstOrDefault(m => type.IsAssignableFrom(m.ReturnType) | ||
| && (m.Name == "op_Implicit" || m.Name == "op_Explicit"))); | ||
| .FirstOrDefault(m => type.IsAssignableFrom(m.ReturnType) && m.Name is "op_Implicit" or "op_Explicit")); |
| #else | ||
| private static readonly ConcurrentDictionary<string, MethodDescriptor> _knownOperators = new ConcurrentDictionary<string, MethodDescriptor>(); | ||
| #endif | ||
| private readonly record struct OperatorKey(string OperatorName, Type Left, Type Right); |
There was a problem hiding this comment.
KurtGokhan
reviewed
Nov 20, 2021
Comment on lines
+878
to
+882
| if (method.Parameters.Length == 0 && arguments.Length == 0) | ||
| { | ||
| // perfect | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Does this mean method will match perfectly if argument lengths are the same, regardless of the argument types? Isn't this wrong, or am I missing something?
There was a problem hiding this comment.
Method has no parameters and JS call has no arguments? What is there to match?
There was a problem hiding this comment.
I had a little brain fart. I saw another thing when reviewing.
Sorry for the trouble. Thank you.
There was a problem hiding this comment.
No worries, I always appreciate reviews and and extra pair of eyes 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the overload selection logic now a bit easier to read and maintain.
struct recordinstead of value tuples and custom codeTryOperatorOverloadingisTrypattern, it should not throw on conversion error, just return falsefixes #1004
fixes #1008