Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES2020 BigInt #1027

Merged
merged 23 commits into from Dec 21, 2021
Merged

ES2020 BigInt #1027

merged 23 commits into from Dec 21, 2021

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Dec 12, 2021

  • can ignore .js file changes with filter - only updating test suite under BigInt folder
  • new BigInt primitive type
  • moved logic towards JsValue.Equals (===, strict) and JsValue.LooseEquals (==)
  • about 800 new test cases passing

There might be things to improve, but I think some refactoring can be left later. I'm probably going to try separate operator overloading via decorators or something to make core logic more concise.

@lahma lahma added the es2020 label Dec 12, 2021
@lahma lahma force-pushed the bigint branch 2 times, most recently from 5263b35 to 0b8ad1d Compare December 13, 2021 19:18
@lahma lahma marked this pull request as ready for review December 16, 2021 14:58
@lahma lahma marked this pull request as draft December 17, 2021 05:18
@lahma
Copy link
Collaborator Author

lahma commented Dec 17, 2021

I think I still need to validate against latest test suite and bigint related tests.

@lahma
Copy link
Collaborator Author

lahma commented Dec 18, 2021

All bigint related tests pass in my custom workbench after two latest commits, still requires new Esprima release for full compatibility.

@lahma lahma marked this pull request as ready for review December 21, 2021 06:03
@lahma lahma merged commit 9d84326 into sebastienros:main Dec 21, 2021
@lahma lahma deleted the bigint branch December 21, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants