added int vs float diff for function overloads #1036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1035
First time contributing here. It felt appropriate to follow and reuse the existing Enum resolution/overloading code and tests.
Also, I added an extra check in the existing Enum resolution code
paramType.GetEnumUnderlyingType() == typeof(int)
becauseEnum.IsDefined
would throw ifparamType.GetEnumUnderlyingType()
is not an int (as in the case of an overloaded function with an uint enum param).