Allowing to use nullable propagation on callables again. Fixed #1041 #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ienros#1041 In `EvaluateCall`, we shouldn't short circuit if we detected that the value is null and the nullable reference returned true, we still need to call to the callable
Accepting PR comments Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
sebastienros
approved these changes
Jan 10, 2022
lahma
approved these changes
Jan 10, 2022
|
GitHub requires merge sync from main before merge, and we cannot do it as source branch is main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
EvaluateCall, we shouldn't short circuit if we detected that the value is null and the nullable reference returned true, we still need to call to the callable