Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JS class to extend CLR type #1049

Merged
merged 1 commit into from Jan 12, 2022

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Jan 11, 2022

I'm probably opening a can of worms here.

fixes #1048

@lahma lahma marked this pull request as ready for review January 11, 2022 18:32
@lahma lahma marked this pull request as draft January 11, 2022 18:44
@sebastienros
Copy link
Owner

You'd better define all the limitations beforehand or bugs/missing features will keep flowing.

@lahma lahma force-pushed the class-extend-clr-type branch 3 times, most recently from 3574ca9 to 66dc95b Compare January 12, 2022 04:55
@lahma lahma marked this pull request as ready for review January 12, 2022 05:13
@lahma lahma merged commit 43d63be into sebastienros:main Jan 12, 2022
@lahma lahma deleted the class-extend-clr-type branch January 12, 2022 05:13
@lahma
Copy link
Collaborator Author

lahma commented Jan 12, 2022

I was able to get it work with my test case which should cover most obvious things, deep inheritance chain with accessing properties from both JS and base CLR type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extending ES6 class from a base CLR type; currently throws with JavascriptException (message: "null")
2 participants