Various Interop fixes #1063
Merged
Various Interop fixes #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! Couldn't spot anything bad logic-wise and think the returning undefined is natural for missing member like JS does, we can revisit when someone finds a problem with the logic 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure about the Dictionary accessor. It now uses
TryGetValueinstead of usingItemand expecting it to throw error when a key is missing. That makes more sense to me logically. But there is this case:https://github.com/sebastienros/jint/compare/main...KurtGokhan:interop-fixes?expand=1#diff-6f0fbc1958b9b5e571672e8b8c8795a77ac611e89ee8bf7fbe31d2d1eb476942R145
I am not sure if the result should be
undefinedor0here.