Always allow operator overloaded conversion #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing #1094 I felt that we should actually always allow implicit/explicit operators for conversion. I've adapted code to prefer
ChangeType
and if it doesn't succeed we can still always try operator overloading, which has semantically the same goal as supportingIConvertible
. So removing checks whether operator overloading is allowed when doing interop, it's already behind allow interop flag anyway.Thoughts @sebastienros @KurtGokhan ?