Add support for generic methods under interop #1103
Conversation
|
If you rebase against main you should get |
|
no problem for switching tabs to spaces - each time I do it (use tabs instead of spaces) - it is accidental. The convention just differs from the other projects I work in - so my editor defaults to tabs - I've grabbed the editor config - will try updating those individual spots you mentioned - see if the editor does the right thing. In case it is of interest I'm using Visual Studio Preview/2022 on a mac. Another note of possible interest is I can't actually run the entire test suite in the JINT solution (so I'm reliant on the CI/CD to perform the test run on the entire test suite for me). Eventually the tests just start failing or timing out and I end up with a zombie dotnet process. I'm not too sure if there is a particular test(s) that causes this - but in case this information is of interest. I think I've correctly resolved all the issues identified - let me know if I missed anything - thanks! Lastly - let me know if you want more details in the description of this PR. Our project is using typescript and so we want to be able to use C# generic methods from the javascript we execute. I have some test code which shows a few different applications. |
ghost
requested a review
from …dows rune had a timeout: Skipped language\statements\class(sourceFile: language/statements/class/dstr-gen-meth-static-obj-ptrn-id-get-value-err.js) [1 ms] vstest.console process failed to connect to testhost process after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.
lahma
changed the title
add support for generic methods