Generic Methods: better generic method support. #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2022 18:09
…riance - where generic arguments are derived from base generic argument type
…rwise generic extension methods that aren't covariant/contravariant won't work with alternate types
|
no rush - but just bumping this PR @lahma + @sebastienros in case you didn't see it. added new tests to show how the existing support for generic extensions is broken. So if you just grab my tests and put them into mainline - you can see how they fail. I have another PR incoming to notify programmers with a "thread safety" exception when they try to use JINT across multiple threads. It's a small update - but I think the wording of the exception and probably the type of exception will require your input. |
ghost
mentioned this pull request
Closed
lahma
approved these changes
Mar 22, 2022
| @@ -1124,6 +1124,19 @@ private static int CalculateMethodScore(Engine engine, MethodDescriptor method, | |||
| return score; | |||
| } | |||
|
|
|||
| internal class AssignableResult | |||
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covariance + contravariance - where generic arguments are derived from base generic argument type