Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date related fixes and improvements #1107

Merged
merged 3 commits into from Mar 25, 2022
Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Mar 12, 2022

Already reviewed in test branch, bringing as only containing date-related fixes.

@lahma
Copy link
Collaborator Author

lahma commented Mar 13, 2022

Comment from @Jither

By the way, a Date.toString() quick-fix, if anyone looks at its code in the future:
return ToDateTime().ToString("ddd MMM dd yyyy HH:mm:ss 'GMT'K", CultureInfo.InvariantCulture);
... should probably be:
return ToDateTime().ToString("ddd MMM dd yyyy HH:mm:ss 'GMT'zzz", CultureInfo.InvariantCulture);
K outputs Z for 0 offset from UTC - meaning the string will be GMTZ (incorrect). zzz outputs +00:00 as it should be - GMT+00:00.

@lahma lahma marked this pull request as ready for review March 25, 2022 17:07
@lahma lahma merged commit 650c0cb into sebastienros:main Mar 25, 2022
@lahma lahma deleted the date-fixes branch March 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant