Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Engine implement IDisposable #1153

Merged
merged 1 commit into from Apr 27, 2022
Merged

Make Engine implement IDisposable #1153

merged 1 commit into from Apr 27, 2022

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Apr 27, 2022 •
edited

  • no-op, but prepares consumers to do the dispose
  • made Engine sealed, let's see if there's an outcry

fixes #423

@lahma lahma enabled auto-merge (squash) April 27, 2022 17:02
@lahma lahma merged commit 100e9f5 into sebastienros:main Apr 27, 2022
@lahma lahma deleted the disposable-engine branch April 27, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disposing of engine references
1 participant
@lahma