Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TimeoutInterval crashing ImportModule #1165

Merged
merged 1 commit into from May 11, 2022
Merged

Fix TimeoutInterval crashing ImportModule #1165

merged 1 commit into from May 11, 2022

Conversation

christianrondeau
Copy link
Contributor

Fixes #1162

lahma
lahma approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lahma lahma merged commit 8c89089 into sebastienros:main May 11, 2022
@christianrondeau christianrondeau deleted the gh-1162 branch May 17, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportModule crashes when Options.TimeoutInterval is used (NullReferenceException in TimeConstraint2)
2 participants
@christianrondeau @lahma