Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode import URI before using it as a file name #1206

Merged
merged 3 commits into from Jun 28, 2022
Merged

Decode import URI before using it as a file name #1206

merged 3 commits into from Jun 28, 2022

Conversation

fluffware
Copy link
Contributor

This fixes imports from paths that contains spaces (and other characters that are escaped in URIs).

lahma
lahma requested changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test case that shows what's being fixed here (and also protects from future regressions)?

Jint/Runtime/Modules/DefaultModuleLoader.cs Outdated Show resolved Hide resolved
lahma
lahma approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@lahma lahma changed the title Decoding import URI before using it as a file name. Decode import URI before using it as a file name Jun 28, 2022
@lahma lahma enabled auto-merge (squash) June 28, 2022 20:49
@lahma lahma merged commit df82672 into sebastienros:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fluffware @lahma