Fix interop stack trace unwind (#1202) #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove quick patch from JintTryStatement introduced in sebastienros#853 * implement "ideal" solution described in sebastienros#853 (try/finally in Engine.Call and Engine.Construct) * change behaviour of JavaScriptException.SetJavaScriptCallstack() so that it will not overwrite the existing stack trace unless explicitly told to * add test
resnickj
commented
Jul 1, 2022
| var stack = engine.Evaluate(Script).AsString(); | ||
| EqualIgnoringNewLineDifferences(@" at Error <anonymous>:3:21 | ||
| at throwIt (message) <anonymous>:3:15 | ||
| at <anonymous>:11:5", stack); |
There was a problem hiding this comment.
Note: this stack trace still isn't quite right, as the Error ctor should not be included. However, that is a separate issue (there are other tests that expect it to be there), which I may try to address in a subsequent PR.
resnickj
commented
Jul 1, 2022
| @@ -1030,7 +1030,8 @@ private static ObjectInstance ToObjectNonObject(Realm realm, JsValue value) | |||
| { | |||
| referencedName ??= "unknown"; | |||
| var message = $"Cannot read property '{referencedName}' of {o}"; | |||
| throw new JavaScriptException(engine.Realm.Intrinsics.TypeError, message).SetJavaScriptCallstack(engine, sourceNode.Location); | |||
| throw new JavaScriptException(engine.Realm.Intrinsics.TypeError, message) | |||
| .SetJavaScriptCallstack(engine, sourceNode.Location, overwriteExisting: true); | |||
There was a problem hiding this comment.
In this case we need to overwrite the existing stack trace (the one that is created within the Error ctor) in order to use the correct location (i.e. the passed source.Location).
lahma
approved these changes
Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1202