Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethrow CLR function exceptions as JS errors #1246

Merged
merged 2 commits into from Jul 26, 2022
Merged

Rethrow CLR function exceptions as JS errors #1246

merged 2 commits into from Jul 26, 2022

Conversation

christianrondeau
Copy link
Contributor

As discussed with @lahma on gitter. This allows using the CatchClrExceptions handler on ClrFunctionInstance. Works for modules and scripts.

lahma
lahma reviewed Jul 26, 2022
View reviewed changes
Jint/Runtime/Intrinsics.cs Outdated Show resolved Hide resolved
lahma
lahma approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lahma lahma enabled auto-merge (squash) July 26, 2022 16:34
@lahma lahma merged commit 8488e48 into sebastienros:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christianrondeau @lahma