Restore public access to JavaScriptException ctor #1259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
resnickj
commented
Aug 15, 2022
resnickj
commented
- This may not be the optimal solution for allowing interop code to raise JS errors, but for the time being it is the most straightfoward and simple thing to do.
* This may not be the optimal solution for allowing interop code to raise JS errors, but for the time being it is the most straightfoward and simple thing to do.
|
Can you please rebase and add the use case as test case into newly created Jint.Tests.PublicInterface test project so we don't accidentally break it again. |
Genteure
added a commit
to Genteure/jint
that referenced
this pull request
Sep 11, 2022
This is the same as pull request sebastienros#1259 with requested test added.
lahma
pushed a commit
that referenced
this pull request
Sep 11, 2022
This is the same as pull request #1259 with requested test added.
|
Handled via second PR containing test coverage, thanks for pursuing this. |
|
Sorry I didn't have a chance to get to this. Thank you @Genteure for doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.