Reduce stack frame size during Call and Construct #1267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
Call
andConstruct
instantiatednew CallStackElement(functionInstance, expression, ExecutionContext);
which effectively became part of the call's stack frame and for deeply nested function invocations (recursion) it really adds up. This PR slims down required constructs and moves instantiation to call stackPush
side. Now the construct now longer takes stack space during the two types of invocations and also the Jint's storage is smaller.Relates to #1159
/cc @KurtGokhan @Jither
Struct layout
Old CallStackElement
New CallStackElement
Benchmarks
Esprima.Benchmark.SunSpiderBenchmark
Call signature
Old
New