New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve global object setup and access performance #1280
Merged
lahma
merged 10 commits into
sebastienros:main
from
lahma:reduce-nested-calls-for-global
Sep 3, 2022
Merged
Improve global object setup and access performance #1280
lahma
merged 10 commits into
sebastienros:main
from
lahma:reduce-nested-calls-for-global
Sep 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Esprima.Benchmark.SunSpiderBenchmark
Jint.Benchmark.StopwatchBenchmark
|
lahma
changed the title
Improve global object setup performance
Improve global object setup and access performance
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through
GlobalEnvironmentRecord
and optimizing it a bit. Biggest change is to removeObjectEnvironmentRecord
as intermediary abstraction for global access and replace with faster patterns.