New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Dispose on enumerator (#1285) #1286

Merged

lahma merged 1 commit into sebastienros:main from jm-merle:main

Sep 6, 2022

Contributor

jm-merle commented Sep 6, 2022

See discussion #1285 : call dispose on enumerator (or execute finally clause on enumerator methods/properties)

Added a call to (_enumerator as IDisposable)?.Dispose() in EnumerableIterator.Close
Added 3 test cases : normal termination, on break, on exception


          Call Dispose on enumerator (sebastienros#1285)

a33419a

lahma approved these changes

View reviewed changes

Collaborator

lahma left a comment

Thanks for the contribution!

lahma merged commit aa614e1 into sebastienros:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment