Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore public access to JavaScriptException ctor #1295

Merged
merged 1 commit into from
Sep 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 38 additions & 0 deletions Jint.Tests.PublicInterface/JavaScriptExceptionTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
using Jint.Native;
using Jint.Native.Error;
using Jint.Runtime;

namespace Jint.Tests.PublicInterface
{
public class JavaScriptExceptionTests
{
[Fact]
public void CanCreateAndThrowJavaScriptException()
{
var engine = new Engine();

engine.SetValue("throw1", () =>
{
throw new JavaScriptException(engine.Realm.Intrinsics.Error, "message 1");
});

engine.SetValue("throw2", () =>
{
throw new JavaScriptException(new JsString("message 2"));
});

Assert.Throws<JavaScriptException>(() =>
{
engine.Evaluate(@"throw1()");
});

var result1 = engine.Evaluate(@"try { throw1() } catch (e) { return e; }");
var error1 = Assert.IsType<ErrorInstance>(result1);
Assert.Equal("message 1", error1.Get("message").ToString());

var result2 = engine.Evaluate(@"try { throw2() } catch (e) { return e; }");
var jsString = Assert.IsType<JsString>(result2);
Assert.Equal("message 2", jsString.ToString());
}
}
}
4 changes: 2 additions & 2 deletions Jint/Runtime/JavaScriptException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ internal JavaScriptException(ErrorConstructor errorConstructor)
_jsErrorException = (JavaScriptErrorWrapperException) InnerException!;
}

internal JavaScriptException(ErrorConstructor errorConstructor, string? message)
public JavaScriptException(ErrorConstructor errorConstructor, string? message)
: base(message, new JavaScriptErrorWrapperException(errorConstructor.Construct(new JsValue[] { message }), message))
{
_jsErrorException = (JavaScriptErrorWrapperException) InnerException!;
}

internal JavaScriptException(JsValue error)
public JavaScriptException(JsValue error)
: base(GetMessage(error), new JavaScriptErrorWrapperException(error, GetMessage(error)))
{
_jsErrorException = (JavaScriptErrorWrapperException) InnerException!;
Expand Down