Fix some Object static methods returning wrong value #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
reviewed
Oct 16, 2022
| @@ -496,7 +496,7 @@ private static JsValue IsSealed(JsValue thisObject, JsValue[] arguments) | |||
| { | |||
| if (arguments.At(0) is not ObjectInstance o) | |||
| { | |||
| return arguments.At(0); | |||
| return true; | |||
There was a problem hiding this comment.
nit: could return JsBoolen.True and JsBoolean.False
lahma
approved these changes
Oct 16, 2022
|
I think that was your 3rd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in specs, these methods should return a boolean. Somehow this is not covered by test262.
Also added test for #206 so it can be closed.