Cache wrapped object returned by WrapObjectHandler #1327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @libaowei on Gitter related to #1321 and #1326, turns out they has some script that rely on some non-standard behavior of a older version of Jint. Because they want to maintain compatibility for those scripts they decided to use a custom object wrapper.
This pull request make the object wrapper cache available to
WrapObjectHandler
through argument, which was their original intention if I understand correctly.