Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize plain object access #1356

Merged
merged 1 commit into from Nov 11, 2022
Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 11, 2022

Now with recently added knowledge about object types, we can check if we are accessing plain basic object and skip virtual dispatch and property descriptor renewal when possible.

Jint.Benchmark.ObjectAccessBenchmark

Diff Method Mean Error Allocated
Old UpdateObjectProperty 265.8 ms 1.06 ms 90.95 MB
New 221.9 ms (-17%) 0.61 ms 60.42 MB (-34%)

@lahma lahma merged commit eeb4865 into sebastienros:main Nov 11, 2022
@lahma lahma deleted the optimize-plain-object branch November 11, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant