Improve date handling and time zone support #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
new-internal-structure-for-date
branch
4 times, most recently
from
94b2ccf
to
f5bf6d1
Compare
lahma
force-pushed
the
new-internal-structure-for-date
branch
2 times, most recently
from
ddd26bc
to
165452b
Compare
lahma
changed the title
lahma
force-pushed
the
new-internal-structure-for-date
branch
from
165452b
to
7c5ac28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change JsDate to be based on long and helper flags. This follows JS semantics better and milliseconds maps to integral number. Tracking invalid dates with flag info about being NaN or Infinity. Also allows to stamp value as .NET DateTime
MinValue/MaxValue.MakeDate/MakeDay/MakeTimestill play with doubles as it's required by the spec and can be arithmetic with very large numbers.Added new hook in options
GetUtcOffsetwhich allows to plugin a strategy for getting better time zone database than available for example in Windows by default.fixes #787