Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable object identity tracking by default under interop #1466

Merged
merged 1 commit into from Feb 23, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Feb 23, 2023

This feature can cause delayed GC and worry amongst users. Let's disable this feature by default so people don't report Jint leaking memory when GC is just delayed due to conditional weak table.

@lahma lahma enabled auto-merge (squash) February 23, 2023 18:18
@lahma
Copy link
Collaborator Author

lahma commented Feb 23, 2023

/cc @ivan-menshikov you now need to explicitly set this in options after next release

@lahma lahma merged commit 24db194 into sebastienros:main Feb 23, 2023
@lahma lahma deleted the disable-identity-tracking-by-default branch February 23, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant