Support inheritance chain of CLR objects with instanceof operator #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I did a small tweak and moved the logic to be inside of |
lahma
changed the title
|
Hoping to see more PRs and next time I'd suggest creating a separate branch for the PR, will make things usually easier 👍🏻 |
|
I can relate the tweak, makes more sense the place 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I implemented the functionality to make instanceof operator behave following the ineritance chain of CLR objects. But, because this not should be the default behavior, I suggest an explicit activation via Options.Runtime or a class Attribute. I made a test for net 6.0 too.
Regards.