Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add net60 target #1515

Merged
merged 1 commit into from Mar 27, 2023
Merged

Add net60 target #1515

merged 1 commit into from Mar 27, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Mar 27, 2023

No description provided.

@lahma lahma enabled auto-merge (squash) March 27, 2023 17:22
@@ -1,3 +1,5 @@
#if !NET6_0_OR_GREATER
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new TFM target just because of this?

NB: I have no idea what it's doing ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance optimization attribute that "does less" when preparing function call. NET 6 has this natively so conflicts. Adding new target to open more optimization paths via some APIs like JsonEncodedText - see gitter chat 😉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some perf benefits from this attribute: sebastienros/esprima-dotnet#339

@lahma lahma merged commit 75a7b12 into sebastienros:main Mar 27, 2023
3 checks passed
@lahma lahma deleted the add-net6-target branch March 27, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants