Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw real JavascriptException location on Module #1522

Merged
merged 1 commit into from Apr 3, 2023
Merged

Throw real JavascriptException location on Module #1522

merged 1 commit into from Apr 3, 2023

Conversation

huanent
Copy link
Contributor

@huanent huanent commented Apr 3, 2023 •
edited by lahma

fixes #1521

@huanent huanent mentioned this pull request Apr 3, 2023
Closed
lahma
lahma approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution and for helping fix this!

@lahma lahma merged commit 6560653 into sebastienros:main Apr 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScriptException location always is start {0,0} end {0,0} when execute a Module script
2 participants
@huanent @lahma