New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES2022 Class fields and static blocks #1546
Conversation
@@ -97,13 +97,13 @@ The entire execution engine was rebuild with performance in mind, in many cases | |||
|
|||
#### ECMAScript 2022 | |||
|
|||
- ❌ Class Fields | |||
- ✔ Class Fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I jumped straight to this line
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" /> | ||
<PackageReference Include="Nullable" Version="1.3.1" PrivateAssets="all" /> | ||
<PackageReference Include="PolySharp" Version="1.13.1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also an interesting option as it adds extension methods too to types: https://github.com/SimonCropp/Polyfill
@sebastienros can you update API key for Jint too? https://github.com/sebastienros/jint/actions/runs/4926629275/jobs/8802463465 |
@Jither objects got some very secret and private fields. Not sure if you want to access them debugging-wise in the future. |
Will see when I have time 😊 Not sure what e.g. the V8 debugger does for them (are class fields even implemented in browsers yet?) - will probably want to keep it similar to that, still. |
This is from MS Edge: |
3915 new test cases passing.