Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES2022 Class fields and static blocks #1546

Merged
merged 24 commits into from May 9, 2023
Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented May 6, 2023

@@ -97,13 +97,13 @@ The entire execution engine was rebuild with performance in mind, in many cases

#### ECMAScript 2022

- Class Fields
- Class Fields
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I jumped straight to this line

<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all" />
<PackageReference Include="Nullable" Version="1.3.1" PrivateAssets="all" />
<PackageReference Include="PolySharp" Version="1.13.1">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator Author

@lahma lahma May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also an interesting option as it adds extension methods too to types: https://github.com/SimonCropp/Polyfill

@lahma lahma marked this pull request as ready for review May 9, 2023 05:04
@lahma lahma merged commit d90b774 into sebastienros:main May 9, 2023
3 checks passed
@lahma lahma deleted the class-static branch May 9, 2023 05:21
@lahma
Copy link
Collaborator Author

lahma commented May 9, 2023

@lahma
Copy link
Collaborator Author

lahma commented May 9, 2023

@Jither objects got some very secret and private fields. Not sure if you want to access them debugging-wise in the future.

@Jither
Copy link
Contributor

Jither commented May 9, 2023

@Jither objects got some very secret and private fields. Not sure if you want to access them debugging-wise in the future.

Will see when I have time 😊 Not sure what e.g. the V8 debugger does for them (are class fields even implemented in browsers yet?) - will probably want to keep it similar to that, still.

@lahma
Copy link
Collaborator Author

lahma commented May 10, 2023

@Jither objects got some very secret and private fields. Not sure if you want to access them debugging-wise in the future.

Will see when I have time 😊 Not sure what e.g. the V8 debugger does for them (are class fields even implemented in browsers yet?) - will probably want to keep it similar to that, still.

This is from MS Edge:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants