Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store identifier in local #1565

Merged
merged 1 commit into from Jun 20, 2023
Merged

Store identifier in local #1565

merged 1 commit into from Jun 20, 2023

Conversation

TechPizzaDev
Copy link
Contributor

ArrayStressBenchmark:

BenchmarkDotNet=v0.13.5, OS=Windows 10 (10.0.19045.3086/22H2/2022Update)
Intel Core i7-4720HQ CPU 2.60GHz (Haswell), 1 CPU, 8 logical and 4 physical cores
.NET SDK=7.0.302
  [Host]     : .NET 6.0.16 (6.0.1623.17311), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.16 (6.0.1623.17311), X64 RyuJIT AVX2

main:

Method Mean Error StdDev Gen0 Gen1 Allocated
Execute 24.45 ms 0.132 ms 0.123 ms 2250.0000 187.5000 7.18 MB
Execute_ParsedScript 22.74 ms 0.106 ms 0.094 ms 2312.5000 93.7500 7.15 MB

PR:

Method Mean Error StdDev Gen0 Gen1 Allocated
Execute 22.85 ms 0.106 ms 0.088 ms 2250.0000 187.5000 7.18 MB
Execute_ParsedScript 21.95 ms 0.076 ms 0.064 ms 2250.0000 250.0000 7.15 MB

Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get as dramatic change as you did between main and this, but as it doesn't hurt I'm merging. Thanks!

BenchmarkDotNet=v0.13.5, OS=Windows 11 (10.0.23481.1000)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK=7.0.304
  [Host]     : .NET 6.0.18 (6.0.1823.26907), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.18 (6.0.1823.26907), X64 RyuJIT AVX2

Jint.Benchmark.ArrayStressBenchmark

Diff Method Mean Error Allocated
Old Execute 10.74 ms 0.086 ms 7.18 MB
New 10.65 ms (-1%) 0.038 ms 7.18 MB (0%)
Old Execute_ParsedScript 10.67 ms 0.030 ms 7.15 MB
New 10.59 ms (-1%) 0.024 ms 7.15 MB (0%)

@lahma lahma merged commit 75b2d70 into sebastienros:main Jun 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants