More improvements for CLR Interop #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viruscamp
commented
Aug 8, 2023
viruscamp
commented
- Simplize nested CLR Type, can be got directly from parent type
- Add more CLR helper functions: clrUnwrap, clrWrap, clrToString, clrType, clrTypeToObject, clrObjectToType. The last 3 need Options.Interop.AllowGetType == true.
- Make CLR objects ToString meaningful: NamespaceReference, TypeReference, ClrFunctionInstance, MethodInfoFunctionInstance
- Make Jint.Repl call ToString when Serialize failed
lahma
reviewed
Aug 9, 2023
|
Nice work and appreciate you improving the interop story! Added some review comments, please take a look. Branch also needs a rebase as it's a merge requirement that all PRs are against latest |
clrUnwrap: cast `obj as ISomeInterface` to `obj` clrWrap: cast `obj` to `obj as ISomeInterface` clrType: get `TypeReference(ISomeInterface)` from `obj as ISomeInterface` clrToString: call `ToString`, mainly for `NamespaceReference`
make CLR objects ToString meaningful: NamespaceReference, TypeReference, ClrFunctionInstance, MethodInfoFunctionInstance
Type value returned from CLR will be TypeReference not ObjectWrapper.
clrTypeToObject: cast `TypeReference(SomeClass)` to `ObjectWrapper(SomeClass)` clrObjectToType: cast `ObjectWrapper(SomeClass)` to `TypeReference(SomeClass)` The two above and clrType are available only Options.Interop.AllowGetType == true
…ected into Engine. Misc changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.