Proxy on clr #1645
Proxy on clr #1645
Conversation
provide detailed message for exceptions in JsProxy donot use ReferenceEquals on data property value comparing
|
Other exceptions in JsProxy should be attached messages, and make tests. It's so boring, I won't do it recently. Next, I may rewrite
|
| let p = new Proxy(o, handler); | ||
| """); | ||
| var ex = Assert.Throws<JavaScriptException>(() => _engine.Evaluate("p.value")); | ||
| AssertJsTypeError(_engine, ex, "'get' on proxy: property 'value' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected '42' but got '32')"); |
There was a problem hiding this comment.
@lahma
Should we comment out all AssertJsTypeError?
As it depends internal implementations and unstable error messages.
Just comment out these for develop usage.
There was a problem hiding this comment.
I think you did great work replicating the V8 error messages and they can stay, we can always tweak later if comes a maintenance burden 👍🏻
improve `JsValue.SameValue` to compare `ObjectWrapper` add a new test `ProxyHandlerGetDataPropertyShouldNotCheckClrType` for `JsString` and `ConcatenatedString`
fix #1643
provide detailed message for exceptions in JsProxy
donot use ReferenceEquals on data property value comparing