Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of empty date string #1666

Merged
merged 1 commit into from Oct 30, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Oct 30, 2023

fixes #1665

@lahma lahma merged commit da7cb51 into sebastienros:main Oct 30, 2023
3 checks passed
@lahma lahma deleted the fix-date-parse-empty-string branch October 30, 2023 18:06
@sebastienros
Copy link
Owner

Surprising there is no ecma test for this.

@lahma
Copy link
Collaborator Author

lahma commented Oct 30, 2023

I was quite surprised too, but it's usually the easy ones - you just need to handle negative string pointer to deleted prototype that's bound to another realm's error constructor inside late bound function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to parse a date with blank value
2 participants