Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark results for NET 8 #1691

Merged
merged 1 commit into from Nov 24, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 24, 2023

No description provided.

@lahma lahma merged commit 4ad19bc into sebastienros:main Nov 24, 2023
2 of 3 checks passed
@lahma lahma deleted the perf-comparison-net8 branch November 24, 2023 20:10
@SebastianStehle
Copy link
Contributor

It got up to 50% faster just because of .NET 8?

@sebastienros
Copy link
Owner

Changes + jump from .net6, didn't realize it was not on 7 before.

@lahma
Copy link
Collaborator Author

lahma commented Nov 24, 2023

There might be some usual fluctuation caused by something while running the tests (please try running the suite on your machine!), but Jint tries its best to use CLR smarts and should benefit like any other using plain old code. SearchValues shim introduced here shouldn't show up in benchmarks AFAIK.

@SebastianStehle
Copy link
Contributor

I know that you are doing a awesome job :)

@lahma
Copy link
Collaborator Author

lahma commented Nov 24, 2023

I'm happy to see Jint faring so well, but the results should show a balance between things one needs from the engine. Jint's strong suites are running simple scripts fast and being conformant to the spec. I'd argue others might have trouble fulfilling the spec requirements and at the same time there are few consumers that would actually need to worry about such weird edge cases / conformance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants