Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return old recursion limit capabilities #1695

Merged
merged 1 commit into from Nov 30, 2023
Merged

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 30, 2023

We can now actually do better than the old limit 960 which was before NET 8

@lahma lahma merged commit 4272c3b into sebastienros:main Nov 30, 2023
2 of 3 checks passed
@lahma lahma deleted the improve-stack branch November 30, 2023 18:53
@sebastienros
Copy link
Owner

Why not use the AggressiveOptimization field?

Does it mean that Dynamic PGO could explain the increase in stack?

@lahma
Copy link
Collaborator Author

lahma commented Nov 30, 2023

I think it's probably the cold start scenario in tests at least. Benchmarks showed that NET 8 made Jint faster after all. Need to use magic number as older targets don't know about this enum member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants