Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further optimize Dtoa and string building #1698

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Further optimize Dtoa and string building #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jint/Native/Array/ArrayPrototype.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ static string StringFromJsValue(JsValue value)
return s;
}

var sb = new ValueStringBuilder(stackalloc char[128]);
var sb = new ValueStringBuilder(stackalloc char[256]);
sb.Append(s);
for (uint k = 1; k < len; k++)
{
Expand Down
20 changes: 8 additions & 12 deletions Jint/Native/BigInt/BigIntPrototype.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,18 +124,14 @@ private JsValue ToBigIntString(JsValue thisObject, JsValue[] arguments)
sb.Append(Digits[d]);
}

#if NET6_0_OR_GREATER
var charArray = sb.Length < 512 ? stackalloc char[sb.Length] : new char[sb.Length];
sb.AsSpan().CopyTo(charArray);
charArray.Reverse();
#else
var charArray = new char[sb.Length];
sb.AsSpan().CopyTo(charArray);
System.Array.Reverse(charArray);
#endif

var s = new string(charArray);
return negative ? '-' + s : s;
if (negative)
{
sb.Append('-');
}

sb.Reverse();

return sb.ToString();
}

/// <summary>
Expand Down
6 changes: 3 additions & 3 deletions Jint/Native/Json/JsonParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ private string ScanPunctuatorValue(int start, char code)

private Token ScanNumericLiteral(ref State state)
{
var sb = new ValueStringBuilder(stackalloc char[128]);
var sb = new ValueStringBuilder(stackalloc char[64]);
var start = _index;
var ch = _source.CharCodeAt(_index);
var canBeInteger = true;
Expand Down Expand Up @@ -309,7 +309,7 @@ private Token ScanStringLiteral(ref State state)
int start = _index;
++_index;

var sb = new ValueStringBuilder(stackalloc char[128]);
var sb = new ValueStringBuilder(stackalloc char[64]);
while (_index < _length)
{
char ch = _source[_index++];
Expand Down Expand Up @@ -379,7 +379,7 @@ private Token ScanStringLiteral(ref State state)
ThrowError(_index, Messages.UnexpectedEOS);
}

string value = sb.ToString();
var value = sb.ToString();
return CreateToken(Tokens.String, value, '\"', new JsString(value), new TextRange(start, _index));
}

Expand Down