Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug StepInto stops at beginning of arrow function #1715

Merged

Conversation

tomatosalat0
Copy link
Contributor

When using StepMode.Into, the debugger callback DebugHandler.Step did not get fired before the execution of a single expression arrow function.

For example, having this statement

[1, 2, 3].map(v => v * 2)

The debugger would not stop before the v * 2 expression - only after.

In contrast, having this statement

[1, 2, 3].map(function(v) { return v * 2; })

The debugger would stop before and after the return v * 2 expression.

Two tests were added, one for the function type and one for the arrow type.

Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lahma lahma merged commit 5ef97b8 into sebastienros:main Jan 3, 2024
3 checks passed
@tomatosalat0 tomatosalat0 deleted the fix/debug-stepinto-arrowfunction branch January 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants