Refactoring for custom module loader support #1731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support fully custom
IModuleLoader
implementations, some code from the abstractModuleLoader
class has been moved into the public staticModuleFactory
class.With these public methods, custom
IModuleLoader
implementations can be created and used without deriving from the abstract classModuleLoader
. This allows custom code to implement certain features like a cache for parsedEsprima.Ast.Module
instances which can be shared across multiple engine instances. The additional methods allow to use a different source specifier for modules instead of the defaultUri.LocalPath
variant used by the default implementation.The behavior of the existing
DefaultModuleLoader
has not been changed.Implementation
The static class allows to create
Jint.Runtime.Modules.Module
instances without publishing the actual implementations likeSourceTextModule
orSyntheticModule
, so these implementations can still be changed without affecting the public API.