Engine execute module resolving #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
approved these changes
Jan 13, 2024
lahma
pushed a commit
to lahma/jint
that referenced
this pull request
Jan 19, 2024
scgm0
pushed a commit
to scgm0/jint
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Non-module scripts can still import modules using the
import()function. However,Engine.ExecuteandEngine.Evaluatealways passedstring.Emptyas the source of the current script even if one was specified.Change
With the change,
ScriptRecordwill get the value ofScript.Location.Sourceas the source. Tests forEngine.ExecuteandEngine.Evalutewith a customIModuleLoaderchecking for a filledreferencingModuleLocationwere added.The behavior for
Engine.Executewithout passing asourcehas not been changed (source is set to be<anonymous>)