Add test code to validate boolean value in the if condition.

[hyzx86]

relate #1801

[lahma]

Why don't you just investigate the problem instead making others do the leg work?

[hyzx86]

Why don't you just investigate the problem instead making others do the leg work?

Sorry, I've already made some attempts. But none of them worked as expected

[hyzx86]

Hi @lahma , I tried to use AddObjectConverter to solve this problem, so far the test passes, but I don't know if the method is correct.

Could you help to review it? thank you.

[BhaaLseN]

I don't think this is supposed to be here, is it? At least I don't see any .NET 8 specific code at a glance?

[hyzx86]

            var valueKind = jsonValue.GetValueKind();

This line ,the GetValueKind() is warning not support net462

[BhaaLseN]

Yes, that method was introduced with .NET 8...but the available NuGet package that ships System.Text.Json still supports .NET Framework 4.6.2 upwards; so it should work there as well. If this wasn't the case, the old code should've errored out already too.

Granted, I don't have any STJ interop scenarios on .NET Framework at the moment, but I still use this in a .NET 6 integration that is waiting to get upgraded to .NET 8. And as far as I can tell, things should work there if you override the package version. I'd have to test this though, and that might be a while.

Maybe gate the converter behind this, and leave the old code as alternative for anyone that isn't on .NET 8 yet? Remember those tests serve as documentation, and having them work for fewer people could be a problem (at least it would be in my head, not sure if others disagree.)

[hyzx86]

Remember those tests serve as documentation, and having them work for fewer people could be a problem (at least it would be in my head, not sure if others disagree.)

Yes, I agree, I think it's enough to provide a concrete example that people can use to transform different complex objects, so we shouldn't worry too much about whether it works in all versions，people will always have a way to make it work😁

[lahma]

Please note that this way does not lead to optimal performance as it's still reflection based - and it's been before too also with Newtonsoft.Json, but if you would want optimal solution performance-wise then a custom ObjectWrapper should be created which would use known types instead of reflection when accessing properties.

[hyzx86]

Thanks for the suggestion, I just don't know why this expression doesn't work with ObjectWrapper , I found out through debugging that it does differ from JsBoolean.False

var result2 = engine.Evaluate("!variables.falseValue");