Use struct for DiyFp #450
Merged
Use struct for DiyFp #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,17 +51,16 @@ internal CachedPower(ulong significand, short binaryExponent, short decimalExpon | |||
| } | |||
|
|
|||
|
|
|||
| internal static int GetCachedPower(int e, int alpha, int gamma, DiyFp cMk) | |||
| internal static (short, DiyFp) GetCachedPower(int e, int alpha, int gamma) | |||
There was a problem hiding this comment.
Would there be less allocations if you used two out values instead of a Tuple ?
There was a problem hiding this comment.
ValueTuple is a struct so it wont' allocate memory. I did quick check on the out alternative and benchmarkdotnet showed both ways to allocate 0B and ValueTuple version being slightly faster (can't explain that).
sebastienros
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By converting DiyFp to struct we can lower memory traffic by about 30% with small performance gain. I'm using the array test again here.
I have also internalized the Dtoa bits so that no poor soul takes dependency on them, I believe they are not something that library should offer as part of the API.
/cc @sebastienros @ayende
Before
After