ES6 Template Strings #570
Merged
ES6 Template Strings #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
es6-literal-string
branch
5 times, most recently
from
2220195
to
4b97612
Compare
| @@ -234,15 +235,15 @@ public static string ToBase(long n, int radix) | |||
| return "0"; | |||
| } | |||
|
|
|||
| var result = new StringBuilder(); | |||
| var result = StringBuilderPool.GetInstance(); | |||
There was a problem hiding this comment.
Would it make sense to have the pool return a disposable instance and release it on disposal?
There was a problem hiding this comment.
I can do that, checked perf and dispose changes my test case from 36.47 ns to 37.77 ns so it's negligble.
| private JsString BuildString() | ||
| { | ||
| var sb = StringBuilderPool.GetInstance(); | ||
| for (var i = 0; i < _templateLiteralExpression.Quasis.Count; i++) |
There was a problem hiding this comment.
Is there a number of fragments under which a concat is faster than using a builder?
There was a problem hiding this comment.
Tried concatenation (+=) against builder and the are pretty much same speed-wise. After 2 placeholders string builder's allocation profile gets better.
* use StringBuilderPool
lahma
force-pushed
the
es6-literal-string
branch
from
4b97612
to
fe04ae6
Compare
|
Rebased and cleaned StringBuilderPool, now using dispose pattern. |
* change StringBuilderPool to be disposable
lahma
force-pushed
the
es6-literal-string
branch
from
fe04ae6
to
9bfa5f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.