Fix array indexing with empty string #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RusKnyaz
reviewed
Sep 3, 2019
| { | ||
| return uint.MaxValue; | ||
| } | ||
|
|
||
| int d = p[0] - '0'; |
There was a problem hiding this comment.
I'm sorry to interfere, but why not use char.IsDigit(p[0]) here? I checked the performance of both approaches - they are identical.
There was a problem hiding this comment.
Well we need the actual value, say 5 to return and then when we detect length being more than 1 when start addition to that value.
ruixiao-yu
pushed a commit
to cyclr/jint
that referenced
this pull request
Feb 13, 2020
ruixiao-yu
added a commit
to cyclr/jint
that referenced
this pull request
Feb 19, 2020
This reverts commit 4d18ac5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #659